feat(service-provider-server): log more detailed information about DNS lookups #1191
Conversation
…S lookups In particular, include whether os-dns-native made lookups using the native OS DNS APIs or not.
| @@ -42,7 +42,8 @@ const config = { | |||
| 'mongodb-client-encryption': 'commonjs2 mongodb-client-encryption', | |||
| kerberos: 'commonjs2 kerberos', | |||
| snappy: 'commonjs2 snappy', | |||
| interruptor: 'commonjs2 interruptor' | |||
| interruptor: 'commonjs2 interruptor', | |||
| 'os-dns-native': 'commonjs2 os-dns-native', | |||
There was a problem hiding this comment.
@gribnoysup Does this look right to you? I’m guessing it’s enough to make this work in mongosh, since we also do the same for kerberos, but I’d want to be sure :)
There was a problem hiding this comment.
Yep, looks good! I know that I said that we should externalize it here (and it's totally the correct thing to do) but what I forgot about is due the way we connect this runtime in Compass strictly speaking it's not even required as we connect the app through dataService first (where os-dns-native will already do all the work) and then we pass the driver connection options to this module
There was a problem hiding this comment.
Right -- but currently, we're still getting a "Missing optional dependency" warning fro mongosh in Compass because of this. I think it might be nice to avoid that :)
In particular, include whether os-dns-native made lookups
using the native OS DNS APIs or not.