Skip to content

Commit

Permalink
fix(build): disable startup snapshot support again for now MONGOSH-1605
Browse files Browse the repository at this point in the history
… (#1687)

See the comments in MONGOSH-1604/MONGOSH-1605. A proper solution
involves at least updates to Node.js core, so just disabling it
again should be a good workaround for now.
  • Loading branch information
addaleax authored Sep 27, 2023
1 parent b2bfdf6 commit cd6e6af
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions packages/build/src/compile/signable-compiler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -176,9 +176,11 @@ export class SignableCompiler {
preCompileHook,
executableMetadata: this.executableMetadata,
// Node.js startup snapshots are an experimental feature of Node.js.
// If, at some point, something breaks because of it, we can always
// go back to using `useCodeCache: true` only.
useNodeSnapshot: true,
// TODO(MONGOSH-1605): Re-enable startup snapshots after figuring out
// issues with running the binary when CPU features differ
// significantly.
useCodeCache: true,
// useNodeSnapshot: true,
});
}
}

0 comments on commit cd6e6af

Please sign in to comment.