optimisation: don't get the shell prompt before executing initialEval…

…uate
mongodb-js · Dec 12, 2024 · 37e3c8b · 37e3c8b
1 parent 6f20f37
commit 37e3c8b
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 10 deletions.
diff --git a/packages/browser-repl/src/components/shell.spec.tsx b/packages/browser-repl/src/components/shell.spec.tsx
@@ -526,7 +526,7 @@ describe('shell', function () {
         return {};
       };
 
-      const initialEvaluate = 'my command';
+      const initialEvaluate = ['command 1', 'command 2'];
       const onOutputChanged = sinon.spy();
       render(
         <ShellWrapper
@@ -537,10 +537,8 @@ describe('shell', function () {
       );
 
       await waitFor(() => {
-        expect(onOutputChanged).to.have.been.called;
+        expect(screen.getByText('rs0:primary')).to.exist;
       });
-
-      expect(screen.getByText('rs0:primary')).to.exist;
     });
   });
 });
diff --git a/packages/browser-repl/src/components/shell.tsx b/packages/browser-repl/src/components/shell.tsx
@@ -159,7 +159,11 @@ interface ShellProps {
   onEditorChanged?: (editor: EditorRef | null) => void;
 }
 
-const normalizeInitialEvaluate = (initialEvaluate: string | string[]) => {
+const normalizeInitialEvaluate = (initialEvaluate?: string | string[]) => {
+  if (!initialEvaluate) {
+    return [];
+  }
+
   return (
     Array.isArray(initialEvaluate) ? initialEvaluate : [initialEvaluate]
   ).filter((line) => {
@@ -455,18 +459,22 @@ const _Shell: ForwardRefRenderFunction<EditorRef | null, ShellProps> = (
 
     setIsFirstRun(false);
 
-    void updateShellPrompt().then(async () => {
-      if (initialEvaluate) {
-        const evalLines = normalizeInitialEvaluate(initialEvaluate);
+    const evalLines = normalizeInitialEvaluate(initialEvaluate);
+    if (evalLines.length) {
+      void (async () => {
         for (const input of evalLines) {
           await onInput(input);
         }
-      }
-    });
+      })();
+    } else {
+      void updateShellPrompt();
+    }
   }, [initialEvaluate, isFirstRun, onInput, updateShellPrompt]);
 
   useEffect(() => {
     rafraf(() => {
+      // Scroll to the bottom every time we render so the input/output will be
+      // in view.
       scrollToBottom();
     });
   });