This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
Fix v3.6.x (and above) download issues for Mac OSX, Windows #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mongodb-js#33 - 'osx' archive naming changed in v3.5 - 'win32' archive naming changed in v3.5 - not all signatures end with trailing whitespace - MongoDB site Downloads send folks to 'fastdl.mongodb.org' - added Test Suite for package/arch/version/os variants - TODOs for 'linux'; 'legacy', 'static', 'debian92', 'rhel57' - TypeScript development tooling w/ `npm run build`
cantremember
changed the title
LoneRifle
approved these changes
Nov 29, 2018
|
you are very welcome, @LoneRifle 👍 |
|
I've not gotten the chance to test this on my machine, but once I do I'll merge to master and have one additional change to support Ubuntu 18 before kicking it out |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33
npm run buildnegotiable: Test Suite coverage
to ensure that i produced a solution that really worked, i added an extensive data-driven Test Suite. it's great for proving out that the package works ... however it's a time sink and its scope of coverage could be reduced
feedback is welcome
negotiable: TODOs
i noticed the following 'operating system' namespaces when looking at all the download options for 'linux':
i can remove any or all of those TODO comments from this commit, at your discretion
negotiable: TypeScript tooling
if you'd rather there wasn't an npm script and that the devDependencies didn't bring in
tsc,i will happily remove those changes
i could also break them off into a separate PR
did not run tsc
trying to merge the results of
npm run buildwill likely reduce spurious conflicts -- probably not a good thing for the Reviewer