perf(NODE-5875): use builtin native crypto #18
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Is there new documentation needed for these changes?
What is the motivation for this change?
Increase decryption performance
Release Highlight
Improve performance by using bundled native crypto APIs
Previously the bindings would rely on the
cryptoCallbacks
option which was an object with javascript functions corresponding to the cipher algorithms used by libmongocrypt. Since supported versions of Node.js always bundle OpenSSL we can rely on the native APIs being available directly to libmongocrypt. This improves decryption performance ~x5.5 since data does not need to pass between native and javascript layers as frequently.The bindings will check for the existence of OpenSSL APIs and will fallback to using the
cryptoCallbacks
if they are not present. This requires building with a version of libmongocrypt that does not link with OpenSSL.Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript