Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): use github app instead of bot user #492

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Conversation

nirinchev
Copy link
Collaborator

Description

This refreshes our ci workflows and switches to using github app tokens instead of the bot user we used to use.

@nirinchev nirinchev requested a review from addaleax November 27, 2024 13:16
Copy link
Collaborator Author

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some whitespace changes due to prettier reformatting the yaml, so this is best reviewed with the "hide whitespace" option.

GITHUB_TOKEN: ${{secrets.PAT}}
run: |
gh pr merge $PULL_REQUEST_NUMBER --squash --delete-branch
git push
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushing directly to main instead of creating a PR to align with our other workflows.


- uses: actions/setup-node@v4
with:
node-version: ^20.x
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The action has been failing for a while because node 18 is not a supported engine.

@nirinchev nirinchev merged commit 94d5ec2 into main Dec 5, 2024
5 checks passed
@nirinchev nirinchev deleted the ni/github-app-token branch December 5, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants