Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add TypeScript to CodeQL #439

Merged
merged 1 commit into from
Aug 6, 2024
Merged

build: add TypeScript to CodeQL #439

merged 1 commit into from
Aug 6, 2024

Conversation

rtritto
Copy link
Contributor

@rtritto rtritto commented Aug 3, 2024

Description

Add TypeScript language to CodeQL.

Checklist

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@addaleax
Copy link
Collaborator

addaleax commented Aug 5, 2024

@rtritto If I understand the GH docs for CodeQL correctly, these are just aliases for each other – just want to check, is the intention of this PR to be explicit about the fact that both JS and TS are being analyzed (and, in that case, would we prefer javascript-typescript as a single value to make it more obvious that that's what's happening, and not two separate analyses)? Or did something actually change w.r.t. the meaning of these labels and are the GH docs out of date?

@rtritto
Copy link
Contributor Author

rtritto commented Aug 6, 2024

Currently projects are JS and TS, so we need both in CodeQL.
I think that can be used a single label (javascript-typescript), I done the commit.

@addaleax addaleax merged commit 240c0a7 into mongodb-js:main Aug 6, 2024
5 checks passed
@rtritto rtritto deleted the codeql-add-ts branch August 6, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants