Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add azure to the ADL $out description & comment COMPASS-7419 #296

Merged
merged 2 commits into from
May 6, 2024

Conversation

lerouxb
Copy link
Collaborator

@lerouxb lerouxb commented Apr 24, 2024

https://jira.mongodb.org/browse/COMPASS-7419

The suggested snippet seemed to have it as the new snippet either in addition to or in place of s3, but our established pattern seems to be to have one option in the snippet and the others documented in the comment so I stuck with that.

Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one text suggestion, also double checking, did you chat with Irwin on the syntax mentioned in the ticket?

packages/mongodb-constants/src/stage-operators.ts Outdated Show resolved Hide resolved
@lerouxb lerouxb merged commit 4ba4317 into main May 6, 2024
5 checks passed
@lerouxb lerouxb deleted the out-azure branch May 6, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants