Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(signing-utils): add ssh2 types and don't override file with gpg signing #205

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

baileympearson
Copy link
Contributor

Two misc fixes:

  • @types/ssh2 is now a prod dependency. I thought this was already the case, but apparently not.

  • with gpg signing, we don't override the original file when signing remotely. This isn't necessary because gpg doesn't sign in place, and was causing issues in Mongosh's CI.

    Semantic Versioning:

    Package versions will be bumped automatically according to the PR title:

    • The words BREAKING CHANGE in the title will cause a major bump to all the packages changed in the PR. All dependants will also have a major bump (dependencies, optionalDependencies, peerDependencies) or a patch bump (devDependencies).
    • A subject starting with feat will cause a minor bump to all the packages changed in the PR. All dependants will also have a minor bump (dependencies, optionalDependencies, peerDependencies) or a patch bump (devDependencies).
    • Any other change to any package will cause a patch bump to the package and all its dependants.
      -->

Description

Open Questions

Checklist

@baileympearson baileympearson merged commit 9b263ee into main Jan 23, 2024
5 checks passed
@baileympearson baileympearson deleted the no-story-misc-fixes branch January 23, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants