chore(signing-utils): add ssh2 types and don't override file with gpg signing #205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two misc fixes:
@types/ssh2 is now a prod dependency. I thought this was already the case, but apparently not.
with gpg signing, we don't override the original file when signing remotely. This isn't necessary because gpg doesn't sign in place, and was causing issues in Mongosh's CI.
Semantic Versioning:
Package versions will be bumped automatically according to the PR title:
BREAKING CHANGE
in the title will cause a major bump to all the packages changed in the PR. All dependants will also have a major bump (dependencies, optionalDependencies, peerDependencies) or a patch bump (devDependencies).feat
will cause a minor bump to all the packages changed in the PR. All dependants will also have a minor bump (dependencies, optionalDependencies, peerDependencies) or a patch bump (devDependencies).patch
bump to the package and all its dependants.-->
Description
Open Questions
Checklist