Apply suggestions from code review

Co-authored-by: Anna Henningsen <[email protected]>
mongodb-js · Feb 26, 2024 · 906985e · 906985e
1 parent c467c15
commit 906985e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/packages/oidc-http-server-pages/src/create-templates.ts b/packages/oidc-http-server-pages/src/create-templates.ts
@@ -49,10 +49,9 @@ function getPageTemplates({
 }): ITemplate[] {
   const templates: ITemplate[] = [];
   for (const paramsSubset of allSubsets(parameters)) {
-    const propsObject = paramsSubset.reduce((obj, prop) => {
-      obj[prop] = placeholder(prop);
-      return obj;
-    }, {} as Record<string, string>);
+    const propsObject = Object.fromEntries(
+      paramsSubset.map((prop) => [prop, placeholder(prop)])
+    );
     const markup = renderStylesToString(
       renderToStaticMarkup(React.createElement(Component, propsObject))
     );

diff --git a/packages/oidc-http-server-pages/src/get-static-page.ts b/packages/oidc-http-server-pages/src/get-static-page.ts
@@ -1,6 +1,6 @@
 import type { ITemplate, HttpServerPage, PageTemplates } from './types';
 
-function findTemplate(templates: ITemplate[], parameterKeys: string[]) {
+function findTemplate(templates: ITemplate[], parameterKeys: string[]): ITemplate | undefined {
   const parametersJoined = parameterKeys.sort().join('-');
   for (const template of templates) {
     const templateParametersJoined = Object.keys(template.parameters)
@@ -13,15 +13,15 @@ function findTemplate(templates: ITemplate[], parameterKeys: string[]) {
 function replacePlaceholders(
   template: ITemplate,
   parameters: Record<string, string | undefined>
-) {
+): string {
   let { html } = template;
   for (const [key, placeholder] of Object.entries(template.parameters)) {
     html = html.replaceAll(placeholder, escapeHTML(parameters[key] as string));
   }
   return html;
 }
 
-function escapeHTML(str: string) {
+function escapeHTML(str: string): string {
   return str
     .replace(/&/g, '&amp;')
     .replace(/</g, '&lt;')
@@ -34,7 +34,7 @@ export function getStaticPage<TPage extends string = HttpServerPage>(
   page: TPage,
   parameters: Record<string, string | undefined>,
   templates?: PageTemplates<TPage>
-) {
+): string {
   if (!templates) {
     templates = require('./templates.json');
   }