Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(serverstats): update top chart write lock percentage of load visual COMPASS-8604 #6553

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

Anemy
Copy link
Member

@Anemy Anemy commented Dec 6, 2024

COMPASS-8604
Small visual bug on how we show the % of write on the load in the top / hottest collections chart. Javascript related (typescript would catch this sort of thing).
Not easily seen which is probably why it's never been fixed. This bug has probably been in there since it was written 5+ years ago lol.

This is the chart for reference:
Screenshot 2024-12-06 at 12 58 58 PM

@github-actions github-actions bot added the fix label Dec 6, 2024
@Anemy Anemy changed the title fix(serverstats): update top write lock visual percentage COMPASS-8604 fix(serverstats): update top chart write lock percentage of load visual COMPASS-8604 Dec 6, 2024
Copy link
Contributor

@paula-stacho paula-stacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, good catch! this really needs a rewrite 🙈 I'd maybe even rename the variables to say 'Write' and 'Read' so that they're not that easy to confuse

@Anemy Anemy merged commit 775f76d into main Dec 16, 2024
26 of 28 checks passed
@Anemy Anemy deleted the COMPASS-8604 branch December 16, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants