Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(atlas-service): pass csrf tokens with the requests COMPASS-8490 #6465

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

gribnoysup
Copy link
Collaborator

We forgot to copy this logic over from mms when setting up the atlas service fetch methods and because the sandbox was implicitly applying those to every request when proxying we didn't notice this locally. This patch updates the atlas-service to the csrf passing logic and also updates the sandbox so that it closer emulates what happens in cloud. I added some unit tests, and the existing sandbox tests should cover the e2e part

@github-actions github-actions bot added the fix label Nov 8, 2024
@gribnoysup gribnoysup added the no release notes Fix or feature not for release notes label Nov 8, 2024
@gribnoysup gribnoysup merged commit f0655e0 into main Nov 8, 2024
23 of 27 checks passed
@gribnoysup gribnoysup deleted the compass-8490-csrf-headers branch November 8, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix no release notes Fix or feature not for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants