Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(connections): send active and inactive connections with "New Connection" telemetry event COMPASS-8476 #6464

Merged
merged 2 commits into from
Nov 11, 2024
Merged

chore(connections): send active and inactive connections with "New Connection" telemetry event COMPASS-8476 #6464

merged 2 commits into from
Nov 11, 2024

Conversation

kraenhansen
Copy link
Contributor

@kraenhansen kraenhansen commented Nov 8, 2024 •
edited
Loading

Description

Merging this PR will:

  • Add two new fields to the "New Connection" event.
  • Supply values for these when a new connection gets established.

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@kraenhansen kraenhansen added the no release notes Fix or feature not for release notes label Nov 8, 2024
@kraenhansen kraenhansen self-assigned this Nov 8, 2024
@kraenhansen kraenhansen changed the title chore(connections): send active and inactive connections with "New Connection" telemetry event chore(connections): send active and inactive connections with "New Connection" telemetry event COMPASS-8476 Nov 8, 2024
@kraenhansen kraenhansen marked this pull request as ready for review November 11, 2024 12:54
@kraenhansen kraenhansen force-pushed the kh/connections-telemetry branch from 18b3875 to 4fb166a Compare November 11, 2024 13:04
@kraenhansen
Copy link
Contributor Author

kraenhansen commented Nov 11, 2024 •
edited
Loading

I managed to resolve the open questions through conversations on Slack 👍

@kraenhansen kraenhansen merged commit 5e7600f into main Nov 11, 2024
32 checks passed
@kraenhansen kraenhansen deleted the kh/connections-telemetry branch November 11, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gribnoysup gribnoysup gribnoysup approved these changes

Assignees

@kraenhansen kraenhansen

Labels
no release notes Fix or feature not for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kraenhansen @gribnoysup