chore(generative-ai): move ai sign in modal to gen ai package from atlas-service COMPASS-8459 #6448
Conversation
| signInWithModalPrompt, | ||
| signInWithoutPrompt, | ||
| } from './store/atlas-signin-reducer'; | ||
| import { signInWithoutPrompt } from './store/atlas-signin-reducer'; |
There was a problem hiding this comment.
Similar to above, this naming should probably be adjusted, no point in calling out that there is no prompt if there is no other option in this service
| @@ -4,7 +4,7 @@ import type { AtlasUserInfo } from './util'; | |||
| export type ArgsWithSignal<T = Record<string, unknown>> = T & { | |||
| signal?: AbortSignal; | |||
| }; | |||
| export type SignInPrompt = 'none' | 'ai-promo-modal'; | |||
| export type SignInPrompt = 'none'; | |||
There was a problem hiding this comment.
We probably should consider how we can remote this type altogether now, I know that it's right now here so that the reducer can trigger the ipc without recursively calling itself, but this is probably more of a a flaw than a feature now that we don't have the second option
There was a problem hiding this comment.
Good callout, it could use an intentional function for each I feel. It's a bit overloaded without benefit at the moment. I'll see what we can do here.
There was a problem hiding this comment.
Related to other comment: not sure if keeping atlas-signin in the name / path here and in other moved files makes sense to be honest
…le-to-gen-ai-package
|
@gribnoysup Going to do your feedback in a follow up pr. I'd like to unblock https://jira.mongodb.org/browse/COMPASS-8378 which will use a lot of this code, and the plugin we're adding to compass-generative-ai. |
Anemy
deleted the
COMPASS-8459-move-generative-ai-sign-in-enable-to-gen-ai-package
branch
COMPASS-8459
No user facing changes.