fix(user-data): use semaphore to limit reads COMPASS-7256 #6427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Oct 31, 2024
| @@ -68,6 +69,7 @@ export class UserData<T extends z.Schema> { | |||
| private readonly serialize: SerializeContent<z.input<T>>; | |||
| private readonly deserialize: DeserializeContent; | |||
| private readonly getFileName: GetFileName; | |||
| private readonly semaphore = new Semaphore(1000); | |||
There was a problem hiding this comment.
The Node.js thread pool for fs operations (UV_THREADPOOL_SIZE) has a default size of 4 or so. I think a lower number, say 50 or 100, would also be fine here and result in similar performance while at the same time still being significantly better at reducing the risk of EMFILE/ENFILE errors
|
|
||
| await Promise.all( | ||
| files.map(([filepath, data]) => writeFileToStorage(filepath, data)) | ||
| ); |
There was a problem hiding this comment.
Wouldn't this test also run the risk of running into file descriptor limitations?
There was a problem hiding this comment.
yeah that's a good point. i'll remove this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes