chore(e2e): adjust the scripts to make it easier to run atlas cloud e2e tests locally #6425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
added
the
no-title-validation
mabaasit
reviewed
Oct 30, 2024
| ATLAS_CLOUD_TEST_CLUSTER_CONNECTION_STRING_JSON="$(atlascli clusters connectionStrings describe $ATLAS_CLOUD_TEST_CLUSTER_NAME -o json)" | ||
| CONNECTION_STRINGS_JSON="$(atlascli clusters connectionStrings describe $ATLAS_CLUSTER_NAME -o json)" | ||
|
|
||
| export COMPASS_E2e_ATLAS_CLOUD_SANDBOX_CLOUD_CONFIG=$( |
There was a problem hiding this comment.
Suggested change
| export COMPASS_E2e_ATLAS_CLOUD_SANDBOX_CLOUD_CONFIG=$( | |
| export COMPASS_E2E_ATLAS_CLOUD_SANDBOX_CLOUD_CONFIG=$( |
There was a problem hiding this comment.
As we are passing this to test-web-sandbox-atlas-cloud evergreen function (as qa), should we check if that's set?
There was a problem hiding this comment.
Or maybe remove it from there as we are now using MCLI_OPS_MANAGER_URL to determine this?
There was a problem hiding this comment.
Yeah, can drop it from evergreen config, forgot about that, makes sense 👍
There was a problem hiding this comment.
Done in e284976 with the typo fix, thanks for spotting!
…r from test-sanbox-with-atlas function
mabaasit
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small follow up to the new e2e capabilities to make it a bit easier to run these locally if needed. I adjusted the implies check in yargs parsing so that you can keep these env in your shell env config without triggering the implies check when not running the tests for cloud (you still need to explicitly provide the
--test-atlas-cloudflag to trigger the test and it's still required to provide all the other options in that case, just not otherwise), also added some detailed instructions for what needs to be manually setup before running those, should be helpful also if we ever need to re-do the user creation