Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compass-global-writes): try/catch and show error when global-writes fetch fails COMPASS-8333 #6408

Merged
merged 9 commits into from
Nov 7, 2024
Merged

fix(compass-global-writes): try/catch and show error when global-writes fetch fails COMPASS-8333 #6408

merged 9 commits into from
Nov 7, 2024

Conversation

djechlin-mongodb
Copy link
Contributor

Description

todo write the rest of the description

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

n/a

Dependents

n/a

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • [] Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@djechlin-mongodb djechlin-mongodb added the no release notes Fix or feature not for release notes label Oct 28, 2024
@github-actions github-actions bot added the fix label Oct 28, 2024
@djechlin-mongodb djechlin-mongodb marked this pull request as ready for review October 31, 2024 15:16
@paula-stacho
Copy link
Contributor

Looks good! Just one forgotten import :) Now that I'm reading it I was thinking if we should add message (and perhaps retry btn) to the UI, but that can be a follow up.

paula-stacho
paula-stacho approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@paula-stacho paula-stacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! you just need to run npm run -w @mongodb-js/compass-global-writes reformat to fix formatting

@djechlin-mongodb djechlin-mongodb merged commit 636a9c4 into main Nov 7, 2024
6 of 7 checks passed
@djechlin-mongodb djechlin-mongodb deleted the COMPASS-8333 branch November 7, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paula-stacho paula-stacho paula-stacho approved these changes

Assignees
No one assigned
Labels
fix no release notes Fix or feature not for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djechlin-mongodb @paula-stacho