Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(compass-schema): "Schema Exported" event COMPASS-8332 #6389

Merged
merged 4 commits into from
Oct 30, 2024
Merged

chore(compass-schema): "Schema Exported" event COMPASS-8332 #6389

merged 4 commits into from
Oct 30, 2024

Conversation

kraenhansen
Copy link
Contributor

@kraenhansen kraenhansen commented Oct 22, 2024 •
edited
Loading

Description

Adds a "Schema Exported" telemetry-event firing when clicking the "Share Schema as JSON" menu item:

Screenshot 2024-10-22 at 19 29 10

I've verified the implementation running

node ./scripts/logserver.js

and

HADRON_METRICS_SEGMENT_API_KEY='ignore' HADRON_METRICS_SEGMENT_HOST='http://localhost:8000' npm start

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

  • None

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@kraenhansen kraenhansen self-assigned this Oct 22, 2024
@kraenhansen kraenhansen changed the title chore(compass-schema): Schema shared event chore(compass-schema): Schema shared event COMPASS-8332 Oct 22, 2024
@kraenhansen kraenhansen force-pushed the kh/schema-shared-event branch from 15fbd21 to b26708a Compare October 22, 2024 17:33
Anemy
Anemy approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one suggestion on reducing some code duplication, not a blocker.

packages/compass-schema/src/stores/store.ts Show resolved Hide resolved
@kraenhansen kraenhansen force-pushed the kh/schema-shared-event branch from b26708a to 55bdb82 Compare October 24, 2024 07:10
@kraenhansen kraenhansen changed the title chore(compass-schema): Schema shared event COMPASS-8332 chore(compass-schema): "Schema Exported" event COMPASS-8332 Oct 24, 2024
@kraenhansen kraenhansen merged commit 1b1f08d into main Oct 30, 2024
30 checks passed
@kraenhansen kraenhansen deleted the kh/schema-shared-event branch October 30, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paula-stacho paula-stacho paula-stacho left review comments

@Anemy Anemy Anemy approved these changes

Assignees

@kraenhansen kraenhansen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kraenhansen @Anemy @paula-stacho