Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(atlas-service): use metricsId for clusterId when doing automation agent requests #6287

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

gribnoysup
Copy link
Collaborator

@gribnoysup gribnoysup commented Sep 26, 2024

One thing I didn't notice when testing this: only serverless should be passing the uniqueId to the backend, other clusters use the metricsId. Also some drive-by fixes:

  • sandbox electron proxy logs were not piped anywhere
  • polling for connections in web was not working right because we never cleaned up the in-flight promise
  • default backend config was not applying correctly in sandbox because the env value was missing

@github-actions github-actions bot added the fix label Sep 26, 2024
@gribnoysup gribnoysup added the no release notes Fix or feature not for release notes label Sep 26, 2024
@gribnoysup gribnoysup merged commit c7c0584 into main Sep 26, 2024
24 of 27 checks passed
@gribnoysup gribnoysup deleted the fix-automation-agent-cluster-id branch September 26, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix no release notes Fix or feature not for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants