Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(scripts): make sure that update-electron script hoists all electron and electron related deps #6279

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

gribnoysup
Copy link
Collaborator

NIghtlies are failing because browserslist version started resolving incorrectly in package-lock and even updating it manually didn't help because npm stopped updating versions for transitive deps for whatever reason causing them to stay on older version and fail during the build. This patch updates the update-electron script to make sure that we're not only hoisting electron, but all the other deps we're updating with it

Copy link

There is an existing patch(es) for this commit SHA:

Please note that the status that is posted is not in the context of this PR but rather the (latest) existing patch and that may affect some tests that may depend on the particular PR. If your tests do not rely on any PR-specific values (like base or head branch name) then your tests will report the same status. If you would like a patch to run in the context of this PR and abort the other(s), comment 'evergreen retry'.

@gribnoysup
Copy link
Collaborator Author

evergreen retry

Copy link

There is an existing patch(es) for this commit SHA that will be aborted:

The status reported will be corresponding to this PR rather than the previous existing ones. If you would like a patch to run for another PR and to abort this one, comment 'evergreen retry' on the corresponding PR.

@gribnoysup gribnoysup merged commit f8d79ba into main Sep 25, 2024
28 of 30 checks passed
@gribnoysup gribnoysup deleted the update-electron-and-fix-the-script branch September 25, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants