chore(web, sidebar): disable creating, deleting, and modifying atlas connections; provide callback prop for connection info modal COMPASS-7883 COMPASS-8229 COMPASS-8230 #6175
Conversation
…connections; provide callback prop for connection info modal
| @@ -221,7 +221,7 @@ export function createInstancesStore( | |||
| const db = | |||
| instance.databases.get(database) ?? | |||
| // We might be adding collection to a new db namespace | |||
| instance.databases.add({ _id: database }); | |||
| instance.databases.add({ _id: database, name: database }); | |||
There was a problem hiding this comment.
Drive-by: small bug here with not passing the name, it's the same value as _id, but compared to collection model is not a derived value on database model, so will be missing until we fetch the db below. Never popped up in compass as an issue, it would just load a milisecond later and show in the UI, but in compass-web we're using this value to render the CTA for adding data to the cluster and passing it to toNS and this breaks if name is missing
| @@ -490,19 +515,22 @@ const ConnectionsNavigation: React.FC<ConnectionsNavigationProps> = ({ | |||
| expanded={expanded} | |||
| /> | |||
| </> | |||
| ) : ( | |||
| )} | |||
| {connections.length === 0 && ( | |||
| <div className={noDeploymentStyles}> | |||
| <Body data-testid="no-deployments-text"> | |||
| You have not connected to any deployments. | |||
There was a problem hiding this comment.
Maybe worth noting that in mms if there are no clusters in the project, we will redirect to the clusters overview page before you even see compass-web rendering, so even though the text here is maybe a bit ill-fitting, real users will never see it anyway
This patch changes some misc stuff related to the compass-web sidebar when atlas connections are shown, in particular:
Example of some of those changes visible: