chore(connections): make sure that getThemeOf method gets updated when colors change #6162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to the big connections refactor I just merged, spotted an issue with this hook when working on refactor, but kept the fix out just to limit the scope of previous PR.
The fix itself is pretty straightforward: just make sure that method depends on actual list of data it needs and not on a stable getter. Maybe a good example to keep in mind for how easy it is to mess up state updates when React hooks are used and how vigilant you need to be when specifying dependencies (including making sure that dependencies used will actually update too)