fix: add shell open events with entrypoints COMPASS-8136 #6106
Conversation
paula-stacho
changed the title
|
PR looks good! Curious, did you find a PR where we have removed it or how did you find the format of the event properties? |
Oooooh! I don't know where I had the information from when I was writing the ticket description but it was a mistake. I dug a bit more into this and realised the existing |
| @@ -291,6 +293,7 @@ const ConnectionsNavigation: React.FC<ConnectionsNavigationProps> = ({ | |||
| return; | |||
| case 'open-shell': | |||
| openShellWorkspace(item.connectionInfo.id, { newTab: true }); | |||
| track('Shell Open', { entrypoint: 'sidebar' }, item.connectionInfo); | |||
There was a problem hiding this comment.
Maybe we don't use a 'Shell '-prefixed name at all if we want to avoid collisions entirely?
There was a problem hiding this comment.
You're right, originally I thought I am following a convention but it's safer to reserve that convention for the in-shell events
Description
Adding
Shell Openevents, withentrypointof eithersidebar|databases|collections|collection.Checklist
Motivation and Context
Open Questions
Dependents
Types of changes