feat(sidebar): Add the shell icon on hover to the connections in the sidebar COMPASS-8050 COMPASS-8071 #6057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
added
the
feature flagged
lerouxb
commented
Jul 24, 2024
| connectionName, | ||
| Sidebar.CreateDatabaseButton | ||
| ) | ||
| await browser.selectConnectionMenuItem( |
There was a problem hiding this comment.
Cleaned this up because selectConnectionMenuItem() now works for the items that aren't collapsed too. Therefore the sidebarConnectionActionButton selector is only necessary for the csfle and non-genuine markers.
lerouxb
changed the title
himanshusinghs
approved these changes
Jul 25, 2024
|
Something odd happening with sidebar tests, might wanna check that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nuance that might be missed is that the way the three dot menu is designed is that it is the "spillover" of the actions that don't fit in the sidebar. So the open shell action actually moved from the menu to the sidebar in between the add database and menu icons. ie. really the number of icons at which point the rest is collapsed into a menu has changed.
This also brings back a test for multiple connections that checks that the icon goes away if the shell is disabled.