fix: save&connect COMPASS-8068 #6037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paula-stacho
force-pushed
the
COMPASS-8068-2
branch
from
98192f6 to
f2e3da0
Compare
paula-stacho
added
the
feature flagged
paula-stacho
force-pushed
the
COMPASS-8068-2
branch
from
6232379 to
4bd5644
Compare
lerouxb
approved these changes
Jul 18, 2024
paula-stacho
force-pushed
the
COMPASS-8068-2
branch
from
b5ccb0e to
036d47f
Compare
paula-stacho
commented
Jul 18, 2024
| is_favorite: Boolean(favorite), | ||
| is_recent: Boolean(lastUsed && !favorite), | ||
| is_favorite: isFavorite, | ||
| is_recent: Boolean(lastUsed && !isFavorite), |
There was a problem hiding this comment.
this is a driveby - noticed via a broken e2e test. the favorite object contains the color and name, which can now exist on non-favorite connections 🙈 . we didn't rename because it would require a migration of the stored connections. the proper way to check for a favorite is via savedConnectionType.
There was a problem hiding this comment.
had to update another unit test: a192470
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aside of renaming the button to save&connect, this PR is trying to make a clearer distinction between 'connect' and 'saveAndConnect', legacy and new code. For example making sure the submitForm is always explicitly one or the other - previously we had inconsistent behaviour between submit via button and submit via keystroke, likely because we didn't notice the other calls. So after I removed the extra "save", we were saving only once in the first case but zero times in the second! 🤦 I blame the complexity of the legacy form, and can't wait for the cleanup 😁 🔥
Also I marked
ConnectFormActionsas legacy and replaced it's unit tests with tests for the newConnectionFormModalActions. Today I learned these are still used for VSCode, but I don't think that's a reason to maintain the separate component - we just need some flags to prepare the new component for VSCode. I created COMPASS-8098 to be done before we do the clean up and enable the new form in VSCode (COMPASS-7762)Scenarios tested:
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes