refactor(compass-connections): remove extra save on connect #6034
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In multiple connections, we've been saving the connection twice when 'Connect' was pressed. The first happened alongside connecting, the other - after connection success - was due to unnoticed default
shouldSaveConnection
in the connect method (used by single connections).This PR is removing the default 'true'. The parameter is also marked for the cleanup after multiple connections become the norm.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes