Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(compass-connections): remove extra save on connect #6034

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

paula-stacho
Copy link
Contributor

@paula-stacho paula-stacho commented Jul 16, 2024

Description

In multiple connections, we've been saving the connection twice when 'Connect' was pressed. The first happened alongside connecting, the other - after connection success - was due to unnoticed default shouldSaveConnection in the connect method (used by single connections).
This PR is removing the default 'true'. The parameter is also marked for the cleanup after multiple connections become the norm.

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@paula-stacho paula-stacho added the feature flagged PRs labeled with this label will not be included in the release notes of the next release label Jul 16, 2024
@paula-stacho paula-stacho changed the title refactor: remove extra save on connect refactor(compass-connections): remove extra save on connect Jul 17, 2024
@paula-stacho paula-stacho merged commit 4361849 into main Jul 17, 2024
30 checks passed
@paula-stacho paula-stacho deleted the double-saving-fix branch July 17, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature flagged PRs labeled with this label will not be included in the release notes of the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants