chore(e2e): add connectionName support to more helpers COMPASS-8002 #6033
Conversation
lerouxb
changed the title
| @@ -41,8 +41,7 @@ export * from './get-feature'; | |||
| export * from './set-feature'; | |||
| export * from './save-favorite'; | |||
| export * from './save-connection-string-as-favorite'; | |||
| export * from './select-connection'; | |||
| export * from './select-connection-menu-item'; | |||
| export * from './sidebar-connection'; | |||
There was a problem hiding this comment.
I combined a bunch of sidebar connection related commands into one file to mirror what we do for workspace management already. Otherwise it is a bit of a proliferation of little files. It might also help if we do move these to page objects because they'd already be together.
| .waitForDisplayed({ reverse: true }); | ||
| await browser.waitUntil( | ||
| async () => { | ||
| // keep retrying the click :( |
There was a problem hiding this comment.
Drive-by. This was something I moved out recently because clicking again won't work if the modal obscures it anyway, but it seems like it was necessary because it became flaky again.
| @@ -59,10 +67,15 @@ export async function closeWorkspaceTabs( | |||
| // are multiple tabs then another tab will immediately become active and | |||
| // trip up the logic that checks that the tab you closed went away. | |||
| const id = await currentActiveTab.getAttribute('id'); | |||
| debug('closing tab', { numTabsStart, id }); | |||
There was a problem hiding this comment.
Just some debugging in case this still flakes.
There was a problem hiding this comment.
should we add todos to clean these up later?
packages/compass-e2e-tests/helpers/commands/collection-workspaces.ts
Outdated
Show resolved
Hide resolved
…ilters and fix a small bug in there
| // confusing. Also this selector is just for the actions button and it is | ||
| // assumed that at this point it is the only one. But the drop confirmation | ||
| // usually catches that. | ||
| await browser.clickVisible(Selectors.SidebarNavigationItemShowActionsButton); |
There was a problem hiding this comment.
This wasn't scoped to the collection. If one collection was active it would show the three dot menu. If you then hover over a second collection it would show that three dot menu too..
Same bug copy/pasted in several other places.
No description provided.