Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compass-sidebar): do not filter out low level items when a top level item matches the filter COMPASS-8026 #6027

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

paula-stacho
Copy link
Contributor

Description

This fixes the scenario where both the top level (connection/database) and low level (database/collection) match the filter. Since we cannot know whether the user is searching for the top or low level item, it is safer to assume the top, so that unfiltered children are available.

See https://jira.mongodb.org/browse/HELP-60975

Before:

Screenshot 2024-07-16 at 10 34 51

After:

Screenshot 2024-07-16 at 10 34 20

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added the fix label Jul 16, 2024
@himanshusinghs himanshusinghs changed the title fix: do not filter low level with a top level match COMPASS-8026 fix(compass-sidebar): do not filter out low level items when a top level item matches the filter COMPASS-8026 Jul 16, 2024
@paula-stacho paula-stacho merged commit 33bb651 into main Jul 16, 2024
30 checks passed
@paula-stacho paula-stacho deleted the COMPASS-8026 branch July 16, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants