Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: align engines and docs with actually supported version #6023

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

gribnoysup
Copy link
Collaborator

You can't bootstrap monorepo anymore with node 16:

npm ERR! engine Not compatible with your version of node/npm: @octokit/[email protected]
npm ERR! notsup Not compatible with your version of node/npm: @octokit/[email protected]
npm ERR! notsup Required: {"node":">= 18"}
npm ERR! notsup Actual:   {"npm":"9.9.3","node":"v16.20.1"}

So I'm updating it to be aligned with what we use in CI. Also some drive-by small changes to CONTRIBUTING

@gribnoysup gribnoysup merged commit fed1b54 into main Jul 15, 2024
7 of 8 checks passed
@gribnoysup gribnoysup deleted the align-engines-with-ci branch July 15, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants