Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): update the test to reduce the flake #5987

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

gribnoysup
Copy link
Collaborator

This failed five times in a row in a single variant before succeeding eventually. I'm not sure this will remove the flake, but should reduce the chances as the failure screenshots were actually showing the shell when the test would fail as if the element is not on the screen. Hopefully waitFor helps to deal with that

@gribnoysup gribnoysup merged commit b0acc2d into main Jul 1, 2024
30 checks passed
@gribnoysup gribnoysup deleted the maybe-less-flake-in-shell-test branch July 1, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant