Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): account for prettier placeholder replacement #5909

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

addaleax
Copy link
Collaborator

Prettier replaces __SUMMARY__ with **SUMMARY**, so just accept either.

Description

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

Prettier replaces `__SUMMARY__` with `**SUMMARY**`, so just accept either.
@github-actions github-actions bot added the fix label Jun 13, 2024
@@ -56,7 +56,7 @@ const securityTestTag = '@securityTest';
}

process.stdout.write(
template.replace(/__SUMMARY__/, [...comments].join('\n\n'))
template.replace(/__SUMMARY__|\*\*SUMMARY\*\*/, [...comments].join('\n\n'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regex <3

@addaleax addaleax added the no release notes Fix or feature not for release notes label Jun 13, 2024
@addaleax addaleax merged commit f9cf69c into main Jun 13, 2024
5 of 7 checks passed
@addaleax addaleax deleted the fix-prettier-placeholder-replacement branch June 13, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix no release notes Fix or feature not for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants