fix: don't include the version number in process.title because it shows in the menubar in macOS Sonoma COMPASS-7513 #5497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmruiz
reviewed
Feb 26, 2024
| @@ -24,7 +24,7 @@ initializeElectronRemote(); | |||
| installEarlyLoggingListener(); | |||
| installEarlyOpenUrlListener(); | |||
|
|
|||
| process.title = `${app.getName()} ${app.getVersion()}`; | |||
| process.title = app.getName(); | |||
There was a problem hiding this comment.
Why can't we just remove it? Shouldn't take the title from the Info.plist?
There was a problem hiding this comment.
process.title also overrides the actual command line, so that tools like ps don't display it (because the command line could include e.g. a connection string with credentials or a --password argument). We do the same in mongosh.
kmruiz
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this was harmless before the release of macOS Sonoma.