Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(generative-ai): add additional accuracy tests COMPASS-7299 #5091

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

Anemy
Copy link
Member

@Anemy Anemy commented Nov 9, 2023

COMPASS-7299
Adds a Spanish test, array project test, and another aggregation test. Also increased the timeout slightly as I'd occasionally get a rate limit.

@@ -44,7 +44,7 @@ const TESTS_TO_RUN_CONCURRENTLY = 3;
// To avoid rate limit we also reduce the time between tests running
// when the test returns a result quickly.
const ADD_TIMEOUT_BETWEEN_TESTS_THRESHOLD_MS = 5000;
const TIMEOUT_BETWEEN_TESTS_MS = 2000;
const TIMEOUT_BETWEEN_TESTS_MS = 3000;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still issues with the rate limit?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw it once on my local when I ran it vs 50 so I figured we might as well be safe here. Shouldn't slow it down too much.

@Anemy Anemy merged commit 200be59 into main Nov 10, 2023
6 checks passed
@Anemy Anemy deleted the COMPASS-7299-add-more-tests branch November 10, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants