fix: pass relaxed: false to EJSON.deserialize() so values won't be promoted COMPASS-7431 #5090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
commented
Nov 9, 2023
| @@ -132,7 +132,7 @@ describe('importJSON', function () { | |||
| hasUnboundArray: false, | |||
| }); | |||
|
|
|||
| const docs = await dataService.find(ns, {}); | |||
| const docs = await dataService.find(ns, {}, { promoteValues: false }); | |||
There was a problem hiding this comment.
Had to add this so I could assert against the values without the values being promoted.
lerouxb
force-pushed
the
import-json-relaxed-false
branch
from
863b390 to
6b6af12
Compare
lerouxb
commented
Nov 9, 2023
| @@ -158,7 +158,7 @@ describe('importJSON', function () { | |||
| throw err; | |||
| } | |||
|
|
|||
| const expectedResult = EJSON.parse(text); | |||
| const expectedResult = EJSON.parse(text, { relaxed: false }); | |||
lerouxb
force-pushed
the
import-json-relaxed-false
branch
from
6b6af12 to
8cb16ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.