chore(data-service, home): create a service provider / locator for data service COMPASS-7410 #5085
Conversation
… up provider in home
| @@ -20,28 +20,18 @@ const getComponent = (name: string) => { | |||
| }; | |||
|
|
|||
| describe('WorkspaceContent [Component]', function () { | |||
| let testAppRegistry: AppRegistry; | |||
| beforeEach(function () { | |||
| testAppRegistry = new AppRegistry(); | |||
There was a problem hiding this comment.
@addaleax for now swithcing it back to global app registry in the useAppRegistryComponent and tests, the usage of those will be removed anyway pretty soon as the plugins we mock here are the next in line to be refactored.
Now that we have an app registry scope for a connected part application, we can't rely on global === local in this part of the app to ease testing
| if (dataService === getState().dataService.dataService) { | ||
| dispatch( | ||
| globalAppRegistryEmit( | ||
| 'export-finished', |
There was a problem hiding this comment.
This event was used in tests but nowhere else and tests could just wait for the dispatched action instead, so I removed it
| ); | ||
| } | ||
|
|
||
| export type RootExportState = ReturnType< | ||
| ReturnType<typeof configureStore>['getState'] | ||
| >; | ||
|
|
||
| export type ExportPluginServices = { |
There was a problem hiding this comment.
Something for later, but I'm starting to think we should probably have some helper types to get those types easier from the returned plugin object maybe? Similar to React.ComponentProps or something like that
…tor export store to use service injection
gribnoysup
force-pushed
the
compass-7410-data-service-provider
branch
from
7928456 to
b5b3c7a
Compare
gribnoysup
force-pushed
the
compass-7410-data-service-provider
branch
from
5a1720b to
f42359b
Compare
This patch introduces a service provider for data service, plugins using data service provider need to be in the connected application tree to function and can access it directly through activate plugin method.
As we already have a few plugins that were updated to the new interface that would benefit from using this service locator, I'm refactoring them to use new mechanism
To avoid blocking work, I'll follow up with the following plugins in a separate PR: