fix(compass-sidebar): convert to ts, fix save connections bug COMPASS-7418 #5077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
commented
Nov 7, 2023
| try { | ||
| await connectionStorage.save(connectionInfo); | ||
| await connectionStorage.save({ connectionInfo }); |
There was a problem hiding this comment.
^ This is what was preventing connections from being saved
There was a problem hiding this comment.
Like completely from the sidebar? Do we miss some test?
There was a problem hiding this comment.
Yeah, we don’t have an e2e test for this
| @@ -1,48 +0,0 @@ | |||
| import toNS from 'mongodb-ns'; | |||
There was a problem hiding this comment.
This file was just completely unused, so I just removed it
| @@ -1,15 +0,0 @@ | |||
| const hadronApp = require('hadron-app'); | |||
There was a problem hiding this comment.
This file and the ones in test/mocks as well, they didn’t seem to actually be consumed anywhere so I just removed them
mcasimir
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes