fix: update .rpm and .deb deps and requirements COMPASS-7203 #4928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
commented
Sep 28, 2023
addaleax
approved these changes
Sep 28, 2023
|
latest electron-installer-redhat (3.0 onwards) requires rpmbuild 4.13 and RHEL7's rpmbuild is older. so I had to downgrade to v2 again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our .rpm and .deb dependencies haven't been updated in a long time and seem to depend on unnecessary things. This has started to become a problem because some distros have removed some of those.
Looking at electron-installer-redhat and electron-installer-debian they both mix in electron's own requirements so we don't have to specify things that electron depends on - just the extras.
Something I didn't solve here and don't think I can is that amazon linux 2023 removed gnome-keyring, so our .rpm package is still not going to be easy to install there.