feat(search-indexes): add a drop down to choose a search index template COMPASS-7173 #4892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
reviewed
Sep 21, 2023
packages/compass-indexes/src/components/search-indexes-modals/base-search-index-modal.tsx
Outdated
Show resolved
Hide resolved
gribnoysup
reviewed
Sep 22, 2023
packages/compass-indexes/src/components/search-indexes-modals/base-search-index-modal.tsx
Outdated
Show resolved
Hide resolved
packages/compass-indexes/src/components/search-indexes-modals/base-search-index-modal.tsx
Outdated
Show resolved
Hide resolved
packages/compass-indexes/src/components/search-index-template-dropdown/index.tsx
Outdated
Show resolved
Hide resolved
packages/compass-indexes/src/components/search-index-template-dropdown/index.tsx
Outdated
Show resolved
Hide resolved
packages/compass-indexes/src/components/search-index-template-dropdown/index.tsx
Outdated
Show resolved
Hide resolved
packages/compass-indexes/src/components/search-index-template-dropdown/index.tsx
Outdated
Show resolved
Hide resolved
gribnoysup
reviewed
Sep 22, 2023
packages/compass-indexes/src/components/search-index-template-dropdown/index.tsx
Outdated
Show resolved
Hide resolved
|
NIT: how come we are excluding this PR from release notes? unless we want to merge this before the next GA we probably want it there |
|
We decided to leave it for the next GA as we've already done the testing and it would mean doing the whole test matrix again today. |
Don't we want this PR appear in the release notes of the GA where it lands? |
kmruiz
added
release notes
and removed
no release notes
|
You are right, changed it. |
lerouxb
reviewed
Sep 26, 2023
packages/compass-indexes/src/components/search-index-template-dropdown/index.tsx
Outdated
Show resolved
Hide resolved
lerouxb
reviewed
Sep 26, 2023
packages/compass-indexes/src/components/search-indexes-modals/base-search-index-modal.spec.tsx
Outdated
Show resolved
Hide resolved
lerouxb
approved these changes
Sep 26, 2023
gribnoysup
approved these changes
Sep 26, 2023
packages/compass-indexes/src/components/search-index-template-dropdown/index.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes