-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: more auto-update logging, disable if not supported COMPASS-7220 #4868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
commented
Sep 19, 2023
lerouxb
commented
Sep 19, 2023
Sample .msi logs:
|
Sample .zip log:
|
Sample .exe logs:
|
addaleax
reviewed
Sep 19, 2023
addaleax
approved these changes
Sep 20, 2023
gribnoysup
approved these changes
Sep 20, 2023
Comment on lines
+626
to
+628
// TODO(COMPASS-7233): This is kinda pointless at the moment because the | ||
// preferences start as disabled and then become enabled the moment they are | ||
// loaded. Which would immediately kick off the state change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think this is not a race condition and just a case for first-time compass run where some of those default properties are not set until we show the welcome modal first time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working theory:
This change: