chore: factor out the inner workings of the indexes table so we can have separate regular and search ones COMPASS-7163 #4820
Conversation
…arate regular and search ones
packages/compass-indexes/src/components/regular-indexes-table/regular-indexes-table.tsx
Outdated
Show resolved
Hide resolved
| rowStyles, | ||
| indexActionsCellStyles, | ||
| tableHeaderStyles, | ||
| cellStyles, | ||
| nestedRowCellStyles, |
There was a problem hiding this comment.
Not really a pattern we use often and leaks a bit more implementation detail than probably needed. Do you think it would be possible to hide this behind the interface of the table, so that it's still the one responsible for rendering rows and cells?
There was a problem hiding this comment.
I tried that at first but I found it awkward without the Row and Cell props exported by leafygreen. I suppose I can make them dumb and only accept a few props..
There was a problem hiding this comment.
I tried. Weird stuff happening in the Row component that I can't figure out so I reverted it again for now. I think we can try again in a follow-up and I'd like to move on for now and unblock people.
lerouxb
force-pushed
the
refactor-indexes-table
branch
from
dc1a0e9 to
94d540b
Compare
lerouxb
force-pushed
the
refactor-indexes-table
branch
from
94d540b to
22227fe
Compare
There was a problem hiding this comment.
It's very weird how we are exporting parts of the table to make it reusable, please, let's open a ticket to sort this out. Approving because https://github.com/mongodb-js/compass/pull/4820/files#r1319760896 but this is really not the way to go about this
|
Filed a ticket: https://jira.mongodb.org/browse/COMPASS-7199 |
So we'd have RegularIndexesTable and SearchIndexesTable and both reuse IndexesTable.