Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(search-indexes): set up search indexes detection COMPASS-7196 #4815

Merged
merged 8 commits into from
Sep 8, 2023

Conversation

mabaasit
Copy link
Contributor

@mabaasit mabaasit commented Sep 7, 2023

Description

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@mabaasit mabaasit changed the title set up support for search indexes chore(search-indexes): set up search indexes detection COMPASS-7196 Sep 7, 2023
@mabaasit mabaasit marked this pull request as ready for review September 7, 2023 10:56
Comment on lines +53 to +56
export const setStatus = (status: SearchIndexesStatus): SetStatusAction => ({
type: ActionTypes.SetStatus,
status,
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setter actions are an an anti-pattern, currently this is only initial value where this is being used, can we pass it to the store as initial state?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ended up with #4821 PR to handle it separately.

@mabaasit mabaasit merged commit 9650ec9 into main Sep 8, 2023
@mabaasit mabaasit deleted the setup-search-support branch September 8, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants