-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compass-schema-validation): optimises the opening of tab COMPASS-5093 #3994
fix(compass-schema-validation): optimises the opening of tab COMPASS-5093 #3994
Conversation
Just double-checking, COMPASS-5093 mentions two other things: using / making sample smaller and adding a button to explicitly run it instead of doing it automatically, is it something we decided not to do, or will this have a follow up? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments. Also the CI failures look legit. You need to reformat your code with prettier and update existing e2e for schema validation (maybe would make sense to add one or two new ones for the functionality you are adding)
packages/compass-schema-validation/src/components/document-preview/document-preview.jsx
Outdated
Show resolved
Hide resolved
packages/compass-schema-validation/src/components/document-preview/document-preview.jsx
Outdated
Show resolved
Hide resolved
@gribnoysup the e2e tests are fixed and I added a few checks for the new behaviour as well. The now failing tests are related to FLE and package test, which as per this discussion is affecting the entire repo. |
packages/compass-schema-validation/src/components/sample-documents/sample-documents.jsx
Outdated
Show resolved
Hide resolved
packages/compass-schema-validation/src/modules/sample-documents.js
Outdated
Show resolved
Hide resolved
packages/compass-schema-validation/src/components/sample-documents/sample-documents.jsx
Outdated
Show resolved
Hide resolved
packages/compass-schema-validation/src/components/sample-documents/sample-documents.jsx
Outdated
Show resolved
Hide resolved
packages/compass-schema-validation/src/components/sample-documents/sample-documents.jsx
Outdated
Show resolved
Hide resolved
packages/compass-schema-validation/src/components/sample-documents/sample-documents.jsx
Outdated
Show resolved
Hide resolved
3d5366d
to
6925276
Compare
6925276
to
7cd30e8
Compare
removes the document count which was not necessary to find the sample of documents matching and not matching the schema
- both valid and invalid sample will now be fetched upon explicit action - the sample aggregation now uses $sample with a predefined max limit
- icon for passed documents changed to checkmark - header text added with an inline definition for sample documents section
…ents/sample-documents.jsx Co-authored-by: Sergey Petushkov <[email protected]>
- PreviewDocument component independently connected to state
- tests now provide Store to the component tree
7cd30e8
to
c7e3422
Compare
This PR removes the document count while fetching sample documents as it was not necessary to find the sample of documents matching and not matching the schemaThis PR changes the way sample documents are fetched for a provided / modified validator. Changes are summarised below:
$sample
with a sample size of10000
as our sample space to match and find documents that could / could not match the set validator.Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes
Preview