..

mongodb-js · Jul 18, 2024 · e50f093 · e50f093
1 parent f2e3da0
commit e50f093
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 12 deletions.
diff --git a/packages/compass-connections/src/components/legacy-connections.tsx b/packages/compass-connections/src/components/legacy-connections.tsx
@@ -199,7 +199,7 @@ function Connections({
                 <ConnectionForm
                   onConnectClicked={onConnectClick}
                   key={activeConnectionId}
-                  onSaveConnectionClicked={saveConnection}
+                  onSaveClicked={saveConnection}
                   initialConnectionInfo={activeConnectionInfo}
                   connectionErrorMessage={connectionErrorMessage}
                   preferences={preferences}

diff --git a/packages/connection-form/src/components/connection-form-actions.spec.tsx b/packages/connection-form/src/components/connection-form-actions.spec.tsx
@@ -6,7 +6,7 @@ import sinon from 'sinon';
 import { ConnectionFormModalActions } from './connection-form-actions';
 
 describe('<ConnectionFormModalActions />', function () {
-  describe.only('Connect Button', function () {
+  describe('Connect Button', function () {
     it('should call onSave function', function () {
       const onSaveSpy = sinon.spy();
       render(

diff --git a/packages/connection-form/src/components/connection-form.spec.tsx b/packages/connection-form/src/components/connection-form.spec.tsx
@@ -46,7 +46,7 @@ describe('ConnectionForm Component', function () {
                 'mongodb://pineapple:orangutans@localhost:27019',
             },
           }}
-          onSaveConnectionClicked={noop}
+          onSaveClicked={noop}
           {...props}
         />
       </PreferencesProvider>
@@ -264,7 +264,7 @@ describe('ConnectionForm Component', function () {
             connectionString: 'pineapples',
           },
         }}
-        onSaveConnectionClicked={noop}
+        onSaveClicked={noop}
       />
     );
     expect(screen.getByText('Invalid connection string "pineapples"')).to.be
@@ -281,7 +281,7 @@ describe('ConnectionForm Component', function () {
             connectionString: 'pineapples',
           },
         }}
-        onSaveConnectionClicked={noop}
+        onSaveClicked={noop}
       />
     );
     expect(screen.getByText(favoriteText).closest('button')).to.be.visible;
@@ -297,7 +297,7 @@ describe('ConnectionForm Component', function () {
             connectionString: 'pineapples',
           },
         }}
-        onSaveConnectionClicked={noop}
+        onSaveClicked={noop}
       />
     );
 
@@ -321,7 +321,7 @@ describe('ConnectionForm Component', function () {
             connectionString: 'mongodb://localhost:27017',
           },
         }}
-        onSaveConnectionClicked={noop}
+        onSaveClicked={noop}
       />
     );
 
@@ -338,7 +338,7 @@ describe('ConnectionForm Component', function () {
             connectionString: 'pineapples',
           },
         }}
-        onSaveConnectionClicked={noop}
+        onSaveClicked={noop}
       />
     );
 
@@ -369,7 +369,7 @@ describe('ConnectionForm Component', function () {
             name: 'foo',
           },
         }}
-        onSaveConnectionClicked={noop}
+        onSaveClicked={noop}
       />
     );
 

diff --git a/packages/connection-form/src/components/connection-form.tsx b/packages/connection-form/src/components/connection-form.tsx
@@ -339,8 +339,8 @@ type ConnectionFormPropsWithoutPreferences = {
   initialConnectionInfo: ConnectionInfo;
   connectionErrorMessage?: string | null;
   onCancel?: () => void;
-  onConnectClicked: (connectionInfo: ConnectionInfo) => void;
-  onSaveAndConnectClicked: (connectionInfo: ConnectionInfo) => Promise<void>;
+  onConnectClicked?: (connectionInfo: ConnectionInfo) => void;
+  onSaveAndConnectClicked?: (connectionInfo: ConnectionInfo) => void;
   onSaveClicked: (connectionInfo: ConnectionInfo) => Promise<void>;
   onAdvancedOptionsToggle?: (newState: boolean) => void;
 };
@@ -466,7 +466,7 @@ function ConnectionForm({
         action === 'saveAndConnect'
           ? onSaveAndConnectClicked
           : onConnectClicked;
-      callback({
+      callback?.({
         ...initialConnectionInfo,
         ...getConnectionInfoToSave(),
         connectionOptions: updatedConnectionOptions,