Skip to content

Commit

Permalink
chore: fix ELSPROBLEMS for all transitive dependencies (#6355)
Browse files Browse the repository at this point in the history
  • Loading branch information
gribnoysup authored Oct 14, 2024
1 parent b3095e5 commit d64b718
Show file tree
Hide file tree
Showing 7 changed files with 58 additions and 70 deletions.
8 changes: 6 additions & 2 deletions .evergreen/functions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -202,11 +202,15 @@ functions:
# Install dependencies
bash ".evergreen/retry-with-backoff.sh" .evergreen/npm_ci.sh
# Will fail if versions of direct dependencies listed in package-lock
# are not matching versions defined in package.json file of any of the
# workspace packages
# TODO: change this to npm ls --all when rest of the mismatched version issues are resolved
npm ls || echo "\nThe \`npm ls\` command failed with mismatched dependencies error. This usually means that the dependency versions listed in package.json are not matching dependencies resolved and recorded in package-lock.json. If you updated package.json files in your PR, inspect the error output and try to re-install offending dependncies to fix the package-lock file."
# This command is very noisy when running from root with --all, store
# the output in a file that will be uploaded with rest of the logs
LS_ALL_STDOUT_FILE="$(npm config get cache)/_logs/$(date -u +"%Y-%m-%dT%H_%M_%SZ")-npm-ls-all.log"
echo "Validating dependencies with \`npm ls --all\`..."
(npm ls --all > $LS_ALL_STDOUT_FILE && echo "No mismatched dependency versions") || echo "\nThe \`npm ls\` command failed with mismatched dependencies error. This usually means that the dependency versions listed in package.json are not matching dependencies resolved and recorded in package-lock.json. If you updated package.json files in your PR, inspect the error output and try to re-install offending dependncies to fix the package-lock file."
bootstrap:
- command: shell.exec
Expand Down
104 changes: 42 additions & 62 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,9 @@
"scripts"
],
"overrides": {
"@types/enzyme": {
"@types/react": "^17.0.5"
}
"@types/react": "^17.0.83",
"@types/react-dom": "^17.0.25",
"react": "^17.0.2",
"react-dom": "^17.0.2"
}
}
2 changes: 1 addition & 1 deletion packages/compass-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"@leafygreen-ui/icon-button": "^15.0.20",
"@leafygreen-ui/info-sprinkle": "^1.0.3",
"@leafygreen-ui/inline-definition": "^6.0.14",
"@leafygreen-ui/leafygreen-provider": "^3.1.11",
"@leafygreen-ui/leafygreen-provider": "^3.1.12",
"@leafygreen-ui/lib": "^13.2.1",
"@leafygreen-ui/logo": "^9.1.1",
"@leafygreen-ui/marketing-modal": "^4.2.1",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ export const ComboboxMenu = React.forwardRef<HTMLDivElement, ComboboxMenuProps>(
children &&
typeof children === 'object' &&
'length' in children &&
children.length > 0
(children as any).length > 0
) {
return <ul className={menuList}>{children}</ul>;
}
Expand Down
4 changes: 3 additions & 1 deletion packages/compass-components/src/hooks/use-theme.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@ const withDarkMode = function <
WrappedComponent.displayName || WrappedComponent.name || 'Component';
ComponentWithDarkMode.displayName = `WithDarkMode(${displayName})`;

return React.forwardRef(ComponentWithDarkMode) as typeof WrappedComponent;
return React.forwardRef(
ComponentWithDarkMode
) as unknown as typeof WrappedComponent;
};

export { Theme, withDarkMode };
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,7 @@ function GenerativeAIInput({
)}
ref={promptTextInputRef}
data-testid="ai-user-text-input"
aria-labelledby=""
aria-label="Enter a plain text query that the AI will translate into MongoDB query language."
placeholder={placeholder}
value={aiPromptText}
Expand Down

0 comments on commit d64b718

Please sign in to comment.