fix(search-indexes): avoid flicker when modal closes COMPASS-7248 (#4934

)
mongodb-js · Oct 2, 2023 · ba757dc · ba757dc
1 parent 7b7bafb
commit ba757dc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/packages/compass-indexes/src/components/search-indexes-modals/base-search-index-modal.tsx b/packages/compass-indexes/src/components/search-indexes-modals/base-search-index-modal.tsx
@@ -165,10 +165,6 @@ export const BaseSearchIndexModal: React.FunctionComponent<
     if (isModalOpen) {
       setIndexName(initialIndexName);
       setIndexDefinition(initialIndexDefinition);
-    } else {
-      // Reset the name and definition when modal is closed.
-      setIndexName('');
-      setIndexDefinition('{}');
       setParsingError(undefined);
     }
   }, [isModalOpen, initialIndexName, initialIndexDefinition]);

diff --git a/packages/compass-indexes/src/modules/search-indexes.ts b/packages/compass-indexes/src/modules/search-indexes.ts
@@ -360,10 +360,11 @@ export default function reducer(
     return {
       ...state,
       updateIndex: {
+        // We do not clear the indexName here to avoid flicker created by LG
+        // Modal as it closes.
         ...state.updateIndex,
         isBusy: false,
         isModalOpen: false,
-        indexName: '',
       },
     };
   }