fixup: fix connection-form tests for FileInput change

mongodb-js · Oct 25, 2024 · 982b11f · 982b11f
1 parent 9c27dd7
commit 982b11f
Show file tree

Hide file tree

Showing 6 changed files with 57 additions and 24 deletions.
diff --git a/packages/compass-components/src/components/file-input.tsx b/packages/compass-components/src/components/file-input.tsx
@@ -210,6 +210,20 @@ export const FileInputBackendProvider: React.FunctionComponent<{
   );
 };
 
+export function createJSDomFileInputDummyBackend(): () => FileInputBackend {
+  return () => ({
+    openFileChooser() {
+      return;
+    },
+    onFilesChosen() {
+      return () => void 0;
+    },
+    getPathForFile(file: File) {
+      return (file as any).path;
+    },
+  });
+}
+
 // Use as:
 //
 // import * as electronRemote from '@electron/remote';

diff --git a/packages/compass-components/src/index.ts b/packages/compass-components/src/index.ts
@@ -21,6 +21,7 @@ import type {
 } from './components/file-input';
 import FileInput, {
   createElectronFileInputBackend,
+  createJSDomFileInputDummyBackend,
   FileInputBackendProvider,
 } from './components/file-input';
 import { OptionsToggle } from './components/options-toggle';

diff --git a/packages/compass-e2e-tests/tests/in-use-encryption.test.ts b/packages/compass-e2e-tests/tests/in-use-encryption.test.ts
@@ -1103,7 +1103,7 @@ describe('CSFLE / QE', function () {
       }
     });
 
-    it('can read QE data stored in a mongodb 6 database', async function () {
+    it.only('can read QE data stored in a mongodb 6 database', async function () {
       // connect without QE and insert some fixture data that we generated against a 6.x database using the shell
       await browser.connectWithConnectionForm({
         hosts: [CONNECTION_HOSTS],

diff --git a/packages/connection-form/src/components/advanced-options-tabs/csfle-tab/csfle-tab.spec.tsx b/packages/connection-form/src/components/advanced-options-tabs/csfle-tab/csfle-tab.spec.tsx
@@ -18,6 +18,8 @@ import { Binary } from 'bson';
 
 import ConnectionForm from '../../../';
 import { getNextKmsProviderName } from './kms-provider-content';
+import { FileInputBackendProvider } from '@mongodb-js/compass-components';
+import { createJSDomFileInputDummyBackend } from '@mongodb-js/compass-components/lib/components/file-input';
 
 const openAdvancedTab = async (
   tabId: 'general' | 'authentication' | 'tls' | 'proxy' | 'advanced' | 'csfle'
@@ -85,20 +87,24 @@ describe('In-Use Encryption', function () {
     };
 
     render(
-      <ConnectionForm
-        initialConnectionInfo={{
-          id: 'conn-1',
-          connectionOptions: {
-            connectionString: 'mongodb://localhost:27017',
-          },
-        }}
-        onSaveAndConnectClicked={(connectionInfo) => {
-          connectSpy(connectionInfo.connectionOptions);
-        }}
-        onSaveClicked={() => {
-          return Promise.resolve();
-        }}
-      />
+      <FileInputBackendProvider
+        createFileInputBackend={createJSDomFileInputDummyBackend()}
+      >
+        <ConnectionForm
+          initialConnectionInfo={{
+            id: 'conn-1',
+            connectionOptions: {
+              connectionString: 'mongodb://localhost:27017',
+            },
+          }}
+          onSaveAndConnectClicked={(connectionInfo) => {
+            connectSpy(connectionInfo.connectionOptions);
+          }}
+          onSaveClicked={() => {
+            return Promise.resolve();
+          }}
+        />
+      </FileInputBackendProvider>
     );
 
     expect(connectSpy).not.to.have.been.called;

diff --git a/...ion-form/src/components/advanced-options-tabs/ssh-tunnel-tab/ssh-tunnel-identity.spec.tsx b/...ion-form/src/components/advanced-options-tabs/ssh-tunnel-tab/ssh-tunnel-identity.spec.tsx
@@ -7,6 +7,8 @@ import type { SSHConnectionOptions } from '../../../utils/connection-ssh-handler
 import SSHTunnelIdentity from './ssh-tunnel-identity';
 import type { ConnectionFormError } from '../../../utils/validation';
 import { errorMessageByFieldName } from '../../../utils/validation';
+import { FileInputBackendProvider } from '@mongodb-js/compass-components';
+import { createJSDomFileInputDummyBackend } from '@mongodb-js/compass-components/lib/components/file-input';
 
 const formFields: {
   key: keyof SSHConnectionOptions;
@@ -49,11 +51,15 @@ describe('SSHTunnelIdentity', function () {
     updateConnectionFormFieldSpy = sinon.spy();
 
     render(
-      <SSHTunnelIdentity
-        errors={[]}
-        sshTunnelOptions={sshTunnelOptions}
-        updateConnectionFormField={updateConnectionFormFieldSpy}
-      />
+      <FileInputBackendProvider
+        createFileInputBackend={createJSDomFileInputDummyBackend()}
+      >
+        <SSHTunnelIdentity
+          errors={[]}
+          sshTunnelOptions={sshTunnelOptions}
+          updateConnectionFormField={updateConnectionFormFieldSpy}
+        />
+      </FileInputBackendProvider>
     );
   });
 

diff --git a/...ges/connection-form/src/components/advanced-options-tabs/tls-ssl-tab/tls-ssl-tab.spec.tsx b/...ges/connection-form/src/components/advanced-options-tabs/tls-ssl-tab/tls-ssl-tab.spec.tsx
@@ -10,6 +10,8 @@ import sinon from 'sinon';
 import ConnectionStringUrl from 'mongodb-connection-string-url';
 
 import SSLTab, { getTLSOptionForConnectionString } from './tls-ssl-tab';
+import { FileInputBackendProvider } from '@mongodb-js/compass-components';
+import { createJSDomFileInputDummyBackend } from '@mongodb-js/compass-components/lib/components/file-input';
 
 describe('SchemaInput', function () {
   let updateConnectionFormFieldSpy: sinon.SinonSpy;
@@ -28,10 +30,14 @@ describe('SchemaInput', function () {
         'mongodb+srv://0ranges:p!neapp1es@localhost/?ssl=true'
       );
       const component = render(
-        <SSLTab
-          connectionStringUrl={testUrl}
-          updateConnectionFormField={updateConnectionFormFieldSpy}
-        />
+        <FileInputBackendProvider
+          createFileInputBackend={createJSDomFileInputDummyBackend()}
+        >
+          <SSLTab
+            connectionStringUrl={testUrl}
+            updateConnectionFormField={updateConnectionFormFieldSpy}
+          />
+        </FileInputBackendProvider>
       );
       rerender = component.rerender;
     });