fix(auto-update-manager): listen to events instead of invokes; broadc…

…ast to all windows, not only the focused one (#5506)
mongodb-js · Feb 27, 2024 · 708287e · 708287e
1 parent 7d3b82a
commit 708287e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/packages/compass/src/main/auto-update-manager.spec.ts b/packages/compass/src/main/auto-update-manager.spec.ts
@@ -305,7 +305,7 @@ describe('CompassAutoUpdateManager', function () {
 
     it('should restart the app if user confirms', async function () {
       const restartToastIpcPrompt = sandbox
-        .stub(ipcMain!, 'broadcastFocused')
+        .stub(ipcMain!, 'broadcast')
         .callsFake((arg) => {
           expect(arg).to.equal('autoupdate:update-download-success');
           setTimeout(() => {
@@ -329,7 +329,7 @@ describe('CompassAutoUpdateManager', function () {
 
     it('should transition to restart dismissed if user does not confirm restart', async function () {
       const restartToastIpcPrompt = sandbox
-        .stub(ipcMain!, 'broadcastFocused')
+        .stub(ipcMain!, 'broadcast')
         .callsFake((arg) => {
           expect(arg).to.equal('autoupdate:update-download-success');
           setTimeout(() => {

diff --git a/packages/compass/src/main/auto-update-manager.ts b/packages/compass/src/main/auto-update-manager.ts
@@ -359,7 +359,7 @@ const STATE_UPDATE: Record<
       this.maybeInterrupt();
 
       if (isDownloadForManualCheck) {
-        ipcMain?.broadcastFocused('autoupdate:update-download-in-progress');
+        ipcMain?.broadcast('autoupdate:update-download-in-progress');
       }
       autoUpdater.checkForUpdates();
     },
@@ -379,7 +379,7 @@ const STATE_UPDATE: Record<
 
       this.maybeInterrupt();
 
-      ipcMain?.broadcastFocused('autoupdate:update-download-success');
+      ipcMain?.broadcast('autoupdate:update-download-success');
     },
   },
   [AutoUpdateManagerState.ManualDownload]: {
@@ -431,7 +431,7 @@ const STATE_UPDATE: Record<
   [AutoUpdateManagerState.DownloadingError]: {
     nextStates: [AutoUpdateManagerState.UserPromptedManualCheck],
     enter: (_updateManager, _fromState, error) => {
-      ipcMain?.broadcastFocused('autoupdate:update-download-failed');
+      ipcMain?.broadcast('autoupdate:update-download-failed');
       log.error(
         mongoLogId(1001000129),
         'AutoUpdateManager',
@@ -663,12 +663,12 @@ class CompassAutoUpdateManager {
       this.setState(AutoUpdateManagerState.UserPromptedManualCheck);
     });
 
-    ipcMain?.handle(
+    ipcMain?.on(
       'autoupdate:update-download-restart-confirmed',
       this.handleIpcUpdateDownloadRestartConfirmed.bind(this)
     );
 
-    ipcMain?.handle(
+    ipcMain?.on(
       'autoupdate:update-download-restart-dismissed',
       this.handleIpcUpdateDownloadRestartDismissed.bind(this)
     );