fix: use the electron version, not the app's version COMPASS-7305 (#4962

) use the electron version, not the app's version
mongodb-js · Oct 6, 2023 · 5249752 · 5249752
1 parent b843e97
commit 5249752
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/packages/hadron-build/commands/release.js b/packages/hadron-build/commands/release.js
@@ -190,9 +190,13 @@ const fixCompass5333 = (CONFIG, done) => {
  * @api public
  */
 const writeVersionFile = (CONFIG, done) => {
-  return CONFIG.write('version', CONFIG.version)
+  // This version will be used by electron-installer-common to determine which
+  // dependencies of electron to include.
+  const version = CONFIG.packagerOptions.electronVersion;
+
+  return CONFIG.write('version', version)
     .then(dest => {
-      cli.debug(format('version written to `%s`', dest));
+      cli.debug(format('version `%s` written to `%s`', version, dest));
       if (done) {
         done(null, true);
       }

diff --git a/packages/hadron-build/lib/target.js b/packages/hadron-build/lib/target.js
@@ -288,6 +288,8 @@ class Target {
     }
     debug(`Writing ${contents.length} bytes to ${dest}`);
     await fs.promises.writeFile(dest, contents);
+
+    return dest; // this is used by the caller
   }
 
   /**
-Original file line number
+Diff line change
@@ Expand Up / @@ -288,6 +288,8 @@ class Target { @@
         }
         debug(`Writing ${contents.length} bytes to ${dest}`);
         await fs.promises.writeFile(dest, contents);
+        return dest; // this is used by the caller
       }
       /**
@@ Expand Down @@