Skip to content

Commit

Permalink
feat(crud): abort in progress update previews COMPASS-7368 (#5068)
Browse files Browse the repository at this point in the history
abort in-progress update previews when new ones come in
  • Loading branch information
lerouxb authored Nov 7, 2023
1 parent 64282fb commit 41b2b79
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions packages/compass-crud/src/stores/crud-store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1153,9 +1153,7 @@ class CrudStoreImpl
try {
preview = await this.dataService.previewUpdate(ns, filter, update, {
sample: 3,
// TODO(COMPASS-7368): aborting the in-flight operation is still buggy,
// regularly causing uncaught MongoRuntimeError rejections
//abortSignal: abortController.signal,
abortSignal: abortController.signal,
});
} catch (err: any) {
if (abortController.signal.aborted) {
Expand Down

0 comments on commit 41b2b79

Please sign in to comment.