npm run check

mongodb-js · Dec 11, 2024 · 12c7d6e · 12c7d6e
1 parent 67a6999
commit 12c7d6e
Show file tree

Hide file tree

Showing 7 changed files with 510 additions and 161 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/compass-aggregations/src/components/stage-toolbar/stage-operator-select.tsx b/packages/compass-aggregations/src/components/stage-toolbar/stage-operator-select.tsx
@@ -72,8 +72,6 @@ export const StageOperatorSelect = ({
       clearable={false}
       data-testid="stage-operator-combobox"
       className={comboboxStyles}
-      // Used for testing to access the popover for a stage
-      popoverClassName={`mongodb-compass-stage-operator-combobox-${index}`}
     >
       {stages.map((stage, index) => (
         <ComboboxOption

diff --git a/packages/compass-components/src/components/combobox-with-custom-option.tsx b/packages/compass-components/src/components/combobox-with-custom-option.tsx
@@ -2,16 +2,10 @@ import React, { useState, useMemo } from 'react';
 import { Combobox } from './leafygreen';
 import type { ComboboxProps } from '@leafygreen-ui/combobox';
 
-// TODO: Make this required
-type SelectValueType<T extends boolean> = NonNullable<
-  ComboboxProps<T>['value']
->;
-type OnChangeType<T extends boolean> = NonNullable<
-  ComboboxProps<T>['onChange']
->;
+type SelectValueType<T extends boolean> = Required<ComboboxProps<T>>['value'];
+type OnChangeType<T extends boolean> = Required<ComboboxProps<T>>['onChange'];
 
 type ComboboxWithCustomOptionProps<T extends boolean, K> = ComboboxProps<T> & {
-  onChange: OnChangeType<T>;
   options: K[];
   renderOption: (option: K, index: number, isCustom: boolean) => JSX.Element;
 };

diff --git a/packages/compass-components/src/components/combobox-with-custom-options.spec.tsx b/packages/compass-components/src/components/combobox-with-custom-options.spec.tsx
@@ -21,7 +21,6 @@ const renderCombobox = (
       renderOption={(o, i) => {
         return <ComboboxOption key={i} value={o.value} />;
       }}
-      onChange={() => {}}
       {...props}
     />
   );

diff --git a/packages/compass-components/src/components/interactive-popover.tsx b/packages/compass-components/src/components/interactive-popover.tsx
@@ -172,7 +172,7 @@ function InteractivePopover<TriggerElement extends HTMLElement>({
         justify={justify ?? 'start'}
         active={open}
         adjustOnMutation
-        usePortal
+        renderMode="portal"
         spacing={spacing ?? 0}
         className={className}
         refEl={triggerRef}

diff --git a/packages/compass-components/src/components/tab-nav-bar.tsx b/packages/compass-components/src/components/tab-nav-bar.tsx
@@ -71,7 +71,7 @@ function TabNavBar({
           data-testid={dataTestId}
           aria-label={ariaLabel}
           className="test-tab-nav-bar-tabs"
-          setSelected={onTabClicked}
+          setSelected={(x) => onTabClicked(x as number)}
           selected={activeTabIndex}
         >
           {tabs.map(({ name, title }, idx) => {

diff --git a/packages/compass-workspaces/src/stores/workspaces.spec.ts b/packages/compass-workspaces/src/stores/workspaces.spec.ts
@@ -6,7 +6,7 @@ import * as workspacesSlice from './workspaces';
 import { _bulkTabsClose } from './workspaces';
 import { TestMongoDBInstanceManager } from '@mongodb-js/compass-app-stores/provider';
 import type { ConnectionInfo } from '../../../connection-info/dist';
-import type { WorkspaceTab } from '../../dist';
+import type { WorkspaceTab } from '../stores/workspaces';
 import { setTabDestroyHandler } from '../components/workspace-close-handler';
 import { createPluginTestHelpers } from '@mongodb-js/testing-library-compass';